https://bugzilla.redhat.com/show_bug.cgi?id=1536780 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hobbes1069@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |hobbes1069@xxxxxxxxx --- Comment #15 from Richard Shaw <hobbes1069@xxxxxxxxx> --- I don't have a review submitted at the moment but I can fix that this week. Here's a quick spec review while I have a mock build going... 1. Need to tweak your release tag. Since this is a prerelease you have the 0 correct but per the guidelines[1] it should be 0.X where in this case X would be 1, so the full package name would be something like: swift-lang-4.1-0.1.20180214git5a1a34b.fc28 Also, since there shouldn't be a problem using more generic global variables, you could remove the "swift..." from each one to aid readability. 2. This is a suggestion not a requirement but it helps readability to put two lines between major sections, i.e. %prep, %build, %install, etc. 3. This doesn't use the typical build system but verbose output is preferred. If you can pass settings directly to CMAKE somehow just set the environment variable "VERBOSE=1". Perhaps just setting prior to the build command will work: export VERBOSE=1 4. What is the purpose of all the symbolic linking? Most of it you're creating links into the builddir but I don't see it used anywhere... A couple you've got hardcoded paths in /usr/lib which you shouldn't do during package building. 5. Since you've pretty much excluded all arches except x86_64 it would be /usr/lib64, but either way you shouldn't be creating files in the build system and it should error out. 6. Is there a reason you're installing into %{_builddir} instead of %{buildroot}? 7. Like your original post you should post new links after every review, include what you've changed in the %changelog, and bump the release so the next one would be 0.2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
