https://bugzilla.redhat.com/show_bug.cgi?id=1547757 --- Comment #2 from Brett Lentz <blentz@xxxxxxxxxx> --- New spec & srpm at the url in comment #1. > One package is missing for it to be successful, python-tree_format: https://pypi.python.org/pypi/tree-format > Package it then add it to the dependencies list: This is a documentation dependency and not a run-time dependency. This missing dependency does not affect the running of the package. > - Why %{_bindir}/%{pkgname} included in the python3 package? This seems curious to have a python3 package with only the binary. Because that's what is requested in https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin "If the executables provide the same functionality independent of whether they are run on top of Python 2 or Python 3, then only the Python 3 version of the executable should be packaged." > - You should also run the tests provided when you have managed to gather all dependencies. As stated in https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites running test suites should be run when practical. Similar to the tree-format dependency, there are dependencies for the tests that are not currently in Fedora. So, running the tests is currently impractical. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
