https://bugzilla.redhat.com/show_bug.cgi?id=1548761 --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Iwicki Artur from comment #1) > >%autosetup -p1 -n %{name}-%{version} > "-n %{name}-%{version}" is the default, you can drop this. > I prefer to keep it that way for consistency if you don't mind. > >%{__install} > Macro forms of system executables should not be used. > https://fedoraproject.org/wiki/Packaging:Guidelines#Macros > Done. > >%{_datadir}/bash-completion/completions > Are you sure this is right? On my Fedora 27, the directory is > "%{_datadir}/bash_completion.d/". I'm pretty certain this is the correct dir. ll /usr/share/bash-completion/ total 72K -rw-r--r--. 1 root root 71K juil. 26 2017 bash_completion drwxr-xr-x. 1 root root 13K févr. 25 01:59 completions drwxr-xr-x. 1 root root 26 déc. 13 14:56 helpers bash_completion.d should be under /etc/. But vendor completions go into /usr. Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/a3ea2b4/nnn.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/jarun/fedora-rawhide-x86_64/00720856-nnn/nnn-1.6-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
