https://bugzilla.redhat.com/show_bug.cgi?id=1548764 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Looks all good, but I'm a bit wary about the phrasing of the Summary and %description. https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description says that any chance of confusion that the package is the trademarked item, should be avoided. I think it'd be better to rephrase the summary as Summary: access google search, google site search, google news from the terminal %description: googler is a power tool to access Google (Web & News) websites and Google Site Search website from the command-line. [...] (I know the %description has a disclaimer at the end, let's be careful here.) Suggestion: %__make → make %{__install} → install (those macros are pointless) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
