https://bugzilla.redhat.com/show_bug.cgi?id=1548142 --- Comment #2 from Germano Massullo <germano.massullo@xxxxxxxxx> --- (In reply to Lubomir Rintel from comment #1) > 0.) Please remove a useless comment: > > > # procedure for package renaming is https://fedoraproject.org/wiki/Package_Renaming_Process Done > 1.) Please drop the useless macro: > > > %global source_name firefox-pkcs11-loader > > Use %{name} in place of %{source_name} Done > 2.) Don't mix tabs and spaces: > > > # old name was firefox-esteidpkcs11loader > > Obsoletes: firefox-esteidpkcs11loader > ^^^^^^^^^^^^^^ > Please replace this with spaces. Done > 3.) Please use macros consistentlt: > > > %dir %{_prefix}/lib/mozilla/pkcs11-modules/ > > %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json > ^^^^^^^^ > %{_prefix} here Done > 4.) Missing dependency on firefox-filesystem > > You install files into %{_prefix}/lib/mozilla and > %{_datadir}/mozilla/extensions that are owned by it Done > 5.) Summary is too long > > > Summary: Helper script for Firefox that sets up the browser for authentication with Estonian ID-card There is no requirement for 80 char length on summary, there is only on description https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description > And doesn't seem to make sense -- what package ships is not a script. > A better choice would be something like: > "Estonian ID-card authentication support for Firefox" it is the same description from upstream https://github.com/open-eid/firefox-pkcs11-loader and it is a package that installs a JSON and an extension that configures Firefox to correctly handle PKCS11. This configuration is required to use correctly the card, but you could also configure manually Firefox instead of installing this package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
