https://bugzilla.redhat.com/show_bug.cgi?id=1548142 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lkundrak@xxxxx --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> --- 0.) Please remove a useless comment: > # procedure for package renaming is https://fedoraproject.org/wiki/Package_Renaming_Process 1.) Please drop the useless macro: > %global source_name firefox-pkcs11-loader Use %{name} in place of %{source_name} 2.) Don't mix tabs and spaces: > # old name was firefox-esteidpkcs11loader > Obsoletes: firefox-esteidpkcs11loader ^^^^^^^^^^^^^^ Please replace this with spaces. 3.) Please use macros consistentlt: > %dir %{_prefix}/lib/mozilla/pkcs11-modules/ > %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json ^^^^^^^^ %{_prefix} here 4.) Missing dependency on firefox-filesystem You install files into %{_prefix}/lib/mozilla and %{_datadir}/mozilla/extensions that are owned by it 5.) Summary is too long > Summary: Helper script for Firefox that sets up the browser for authentication with Estonian ID-card And doesn't seem to make sense -- what package ships is not a script. A better choice would be something like: "Estonian ID-card authentication support for Firefox" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
