[Bug 1532042] Review Request: compton - Compositor for X11

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jskarvad@xxxxxxxxxx



--- Comment #16 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> ---
The versioning is still wrong, see [1] and [2] for details. It should be:

Version: 0.1
Release: 0.1.beta3%{?dist}

And you should fix Source0 tag and add '-n %{name}-%{version}_beta3' after the
autosetup.

Of course you can use macros, e.g.:

%global ver 0.1
%global prever beta3

Version: %{ver}
Release: 0.1%{?prever:.%{prever}}%{?dist}
...
Source0:
https://github.com/AxelSilverdew/compton/archive/v%{version}%{?prever:_%{prever}}.tar.gz#/%{name}-%{version}%{?prever:_%{prever}}.tar.gz
...
%autosetup -n %{name}-%{version}%{?prever:_%{prever}}

Also note the #/ part in Source0, it's to give the resulting archive proper
name, it's described in [3].

[1] https://fedoraproject.org/wiki/Packaging:Versioning#Prerelease_versions
[2] https://fedoraproject.org/wiki/Package_Versioning_Examples
[3] https://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux