https://bugzilla.redhat.com/show_bug.cgi?id=1491492 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: Coturn - |Review Request: coturn - |TURN/STUN & ICE Server |TURN/STUN & ICE Server --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Simplify your %files. coturn-turnserver.service is not a config file and should rot be marked as %config. Don't mark the manpages as %doc Don't add the .gz extension for man pages, use .* instead because the compression could change in the future. %files %license %{_docdir}/%{name}/LICENSE %{_bindir}/turnserver %{_bindir}/turnadmin %attr(0750,coturn,coturn) %{_localstatedir}/run/%{name} %attr(0640,coturn,coturn) %{_localstatedir}/db/turndb %{_unitdir}/coturn-turnserver.service %config(noreplace) %{_sysconfdir}/sysconfig/%{name} %config %{_sysconfdir}/sysusers.d/coturn.conf %config %{_tmpfilesdir}/coturn.conf %dir %attr(-,coturn,coturn) %{_sysconfdir}/%{name} %config(noreplace) %attr(0644,coturn,coturn) %{_sysconfdir}/%{name}/turnserver.conf %doc %{_docdir}/%{name} %exclude %doc %{_docdir}/%{name}/README.turnutils %exclude %doc %{_docdir}/%{name}/LICENSE %{_mandir}/man1/coturn.1.* %{_mandir}/man1/turnserver.1.* %{_mandir}/man1/turnadmin.1.* %{_datadir}/%{name} %files utils %{_bindir}/turnutils_peer %{_bindir}/turnutils_stunclient %{_bindir}/turnutils_uclient %{_bindir}/turnutils_oauth %{_bindir}/turnutils_natdiscovery %{_datadir}/%{name}/etc/turn_client_cert.pem %{_datadir}/%{name}/etc/turn_client_pkey.pem %{_mandir}/man1/turnutils.1.* %{_mandir}/man1/turnutils_*.1.* %doc %{_docdir}/%{name}/README.turnutils %files client-libs %license %{_docdir}/%{name}/LICENSE %{_libdir}/libturnclient.a %files client-devel %{_includedir}/turn -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
