https://bugzilla.redhat.com/show_bug.cgi?id=1546648 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source address are Ok. Source archive (SHA-256: 37f071a2cf4ba8f090a2297c6482b7a2c509eb52dcd6ce5d8035d4ee2c6824b1) is original. Ok. Summary verified from lib/IO/Socket/Socks.pm. Ok. Description verified from lib/IO/Socket/Socks.pm. Ok. License verified from lib/IO/Socket/Socks.pm and Makefile.PL. Ok. No XS code, noarch BuildArch is Ok. Build-requires are Ok. All tests pass. Ok. Tests that use the Internet (SOCKS_SLOW_TESTS) are not executed. Ok. $ rpmlint perl-IO-Socket-Socks.spec ../SRPMS/perl-IO-Socket-Socks-0.74-1.fc28.src.rpm ../RPMS/noarch/perl-IO-Socket-Socks-0.74-1.fc28.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-IO-Socket-Socks-0.74-1.fc28.noarch.rpm drwxr-xr-x 2 root root 0 Feb 19 13:16 /usr/share/doc/perl-IO-Socket-Socks -rw-r--r-- 1 root root 3279 May 4 2017 /usr/share/doc/perl-IO-Socket-Socks/Changes -rw-r--r-- 1 root root 240 Oct 15 2016 /usr/share/doc/perl-IO-Socket-Socks/README -rw-r--r-- 1 root root 7260 Feb 19 13:16 /usr/share/man/man3/IO::Socket::Socks.3pm.gz drwxr-xr-x 2 root root 0 Feb 19 13:16 /usr/share/perl5/vendor_perl/IO drwxr-xr-x 2 root root 0 Feb 19 13:16 /usr/share/perl5/vendor_perl/IO/Socket -rw-r--r-- 1 root root 72238 May 4 2017 /usr/share/perl5/vendor_perl/IO/Socket/Socks.pm File layout and permissions are Ok. TODO: Consider packaging `examples' subdirectory as a documentation. $ rpm -q --requires -p ../RPMS/noarch/perl-IO-Socket-Socks-0.74-1.fc28.noarch.rpm |sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(Carp) 1 perl(constant) 1 perl(Errno) 1 perl(Exporter) 1 perl(IO::Select) 1 perl(IO::Socket::IP) >= 0.36 1 perl(overload) 1 perl(Socket) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Constrain `perl(constant)' with `>= 1.03' (Makefile.PL:9). TODO: Constrain `perl(Socket)' with `>= >= 1.94' (Makefile.PL:9). $ rpm -q --provides -p ../RPMS/noarch/perl-IO-Socket-Socks-0.74-1.fc28.noarch.rpm |sort -f | uniq -c 1 perl(IO::Socket::Socks) = 0.74 1 perl(IO::Socket::Socks::Debug) 1 perl(IO::Socket::Socks::Error) 1 perl(IO::Socket::Socks::ReadOnlyVar) 1 perl(IO::Socket::Socks::SocketClassVar) 1 perl-IO-Socket-Socks = 0.74-1.fc28 Binary provides are Ok. The package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=25158861). Ok. This package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
