[Bug 1546459] Review Request: svgo-inkscape - Extension to optimize SVG files for Inkscape

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1546459



--- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Luya Tshimbalanga from comment #2)
> > 
> >  - Second svgo.js depends on svgo itself, which is a node module. That's why
> > there is a package.json provided. You should thus run "npm install" in the
> > svgo-inkscape directory to install the required modules.
> 
> Looking at the nodejs guideline
> https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/
> Packagers#Installing_Modules, it looks like using "npm install" is
> discouraged. Is there a better method instead?

Yes my bad, internet is not available in Koji so this wouldn't work anyway.
What you need to do instead is to package the bundled modules:

 - nodejs-svgo

Use npm2rpm as a startup point. Look at other nodejs SPEC files to help you
(https://src.fedoraproject.org/group/nodejs-sig). I,ve checked and all the
dependencies are already packaged.

nodejs-minimist is already packaged too, just add npm(minimist) as a RR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux