https://bugzilla.redhat.com/show_bug.cgi?id=1541566 --- Comment #12 from Matthew Ruszczyk <mruszczyk17@xxxxxxxxx> --- (In reply to William Moreno from comment #10) > From the build log > > %make_build -C src > > + /usr/bin/make -O -j6 -C src > make: Entering directory '/builddir/build/BUILD/whipper-0.6.0/src' > accuraterip-checksum build options: > CFLAGS = -g -std=c99 > LDFLAGS = -lsndfile > CC = cc > make: Leaving directory '/builddir/build/BUILD/whipper-0.6.0/src' > make: Entering directory '/builddir/build/BUILD/whipper-0.6.0/src' > CC accuraterip-checksum.c > make: Leaving directory '/builddir/build/BUILD/whipper-0.6.0/src' > make: Entering directory '/builddir/build/BUILD/whipper-0.6.0/src' > CC -o accuraterip-checksum > make: Leaving directory '/builddir/build/BUILD/whipper-0.6.0/src' > > and %make_install -C src are not necesaries because %py2_build and > %py2_install do the work to put the executable file in %{bindir} > > running install_scripts > Installing whipper script to > /builddir/build/BUILDROOT/whipper-0.6.0-5.fc28.x86_64/usr/bin > > Remove those two lines and this package will ready to go. Thank you very much for the advice. I am a little bit confused however. Removing either line has the package fail to build. Those lines are building a separate c binary called accuraterip-checksum https://github.com/JoeLametta/whipper/tree/master/src. As far as I can tell %py2_build and %py2_install do not touch that directory at all. If I missed something about how to execute the python2 macros I would love to find out. (In reply to William Moreno from comment #11) > Also note that for Fedora 29 you will need to add BuildRequires: gcc > > https://fedoraproject.org/wiki/Changes/Remove_GCC_from_BuildRoot Thank you, I had seen this, just did not want to edit the package another time during this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
