https://bugzilla.redhat.com/show_bug.cgi?id=1546394 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, Same as before: - This should be in the -devel subpackage: %{_libdir}/libopen_amp.so See https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages - Your -devel subpackage should require the main package: %package devel Summary: Development files for OpenAMP Requires: %{name}%{?_isa} = %{version}-%{release} Consequently you don't need to add %license LICENSE.md in the -devel subpackage. - There should probably be a %make_build before %make_install to use parallel computation: %build %cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir} \ -DCMAKE_INCLUDE_PATH=%{_includedir}/libmetal/ \ -DCMAKE_LIBRARY_PATH=%{_libdir} \ -DWITH_STATIC_LIB=OFF \ -DWITH_APPS=ON . %make_build - It's also usual to build in a subdir: %build mkdir build && cd build %cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir} \ -DCMAKE_INCLUDE_PATH=%{_includedir}/libmetal/ \ -DCMAKE_LIBRARY_PATH=%{_libdir} \ -DWITH_STATIC_LIB=OFF \ -DWITH_APPS=ON .. %make_build %install cd build %make_install - Use a more meaningful name for the archive, with: Source0: https://github.com/OpenAMP/open-amp/archive/v%{version}/%{name}-%{version}.tar.gz - Not an error, just a preference: you could move %ldconfig_scriptlets after %install -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
