https://bugzilla.redhat.com/show_bug.cgi?id=1507103 --- Comment #43 from Jan Friesse <jfriesse@xxxxxxxxxx> --- @digimer: - Postun is on correct location, no worries - "%preun -n kronosnetd" is also corrent - But %{?systemd_requires} is not on correct location. It basically expands to: ``` Requires(post): systemd Requires(preun): systemd Requires(postun): systemd ``` so it should be in the kronosnetd part. (do not move BuildRequires: systemd, just %{?systemd_requires} ). - About license, I would let kronosnet License (only main package, other should be as they are) field as it was (so GPL + LGPL), because this is correct license for SRPM. - pkgconfig was (at least from my side) optional so nice job. Please fix the two things (License + location of %{?systemd_requires}) and knet should be good to go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
