https://bugzilla.redhat.com/show_bug.cgi?id=1507103 --- Comment #39 from Jan Friesse <jfriesse@xxxxxxxxxx> --- @digimer: - You've forgot to update changelog - For kronosnetd: * As was noted in previous comment, please add postun ``` %postun -n kronosnetd %systemd_postun kronosnetd.service ``` * Please fix the "%preun -n kronosnetd" section similar way as postun (= no need to check 0%{?systemd_preun:1}) * Add %{?systemd_requires} as described in https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd That's all from me. Some of the @poki comments are still not solved and may be useful: - License - It took me a while to parse what poki meant, and I can agree with him that License field may be more specific. So main idea is: * License of kronosnetd should be GPLv2+, because it is application * License of libknet* should be LGPLv2+, simply because they are libraries But let's quickly check with Fabio what he thinks about it. - Idea of using pkgconfig(foo) seems to be quite nice, could you please give it a try? (just to recap): libqb-devel -> pkgconfig(libqb) xz-devel -> pkgconfig(liblzma) zlib-devel -> pkgconfig(zlib) bzip2-devel -> pkgconfig(bzip2) lz4-devel -> pkgconfig(liblz4) nss-devel -> pkgconfig(nss) # We don't need to require on nspr-devel then openssl-devel -> pkgconfig(openssl) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
