https://bugzilla.redhat.com/show_bug.cgi?id=1544468 --- Comment #7 from Marek Tamaskovic <mtamasko@xxxxxxxxxx> --- Issues: ======= - Dist tag is present. - Header files in -devel subpackage, if present. Note: fapolicyd-debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/event.h fapolicyd-debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/file.h fapolicyd- debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/lru.h fapolicyd-debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/message.h fapolicyd- debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/mounts.h fapolicyd-debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/notify.h fapolicyd- debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/nv.h fapolicyd- debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/object-attr.h fapolicyd-debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/object.h fapolicyd- debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/policy.h fapolicyd-debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/process.h fapolicyd- debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/queue.h fapolicyd-debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/rules.h fapolicyd-debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/subject-attr.h fapolicyd- debugsource : /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/subject.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/mtamasko/Work/pkg- review/fapolicyd/review-fapolicyd/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL Other issues: ============= [!]: %build honors applicable compiler flags or justifies otherwise. 'rpm_build_macro is not applied' [!]: Package consistently uses macros (instead of hard-coded directory names). 'path /sbin is not a macro %{_sbindir}' 'log path is not using macro %{_localstatedir}/log' Rpmlint ------- Checking: fapolicyd-0.8.5-1.x86_64.rpm fapolicyd-debuginfo-0.8.5-1.x86_64.rpm fapolicyd-debugsource-0.8.5-1.x86_64.rpm fapolicyd-0.8.5-1.src.rpm fapolicyd.x86_64: W: spelling-error %description -l en_US whitelisting -> white listing, white-listi ng, whitewashing fapolicyd.x86_64: W: spelling-error %description -l en_US fanotify -> fa notify, fa-notify, notify fapolicyd.x86_64: W: non-standard-gid /etc/fapolicyd fapolicyd fapolicyd.x86_64: E: non-standard-dir-perm /etc/fapolicyd 750 fapolicyd.x86_64: W: non-standard-gid /etc/fapolicyd/fapolicyd.mounts fapolicyd fapolicyd.x86_64: W: non-standard-gid /etc/fapolicyd/fapolicyd.rules fapolicyd fapolicyd.x86_64: W: log-files-without-logrotate ['/var/log/fapolicyd-access.log'] fapolicyd-debugsource.x86_64: W: no-documentation fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/e vent.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/e vent.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/f apolicyd.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/f ile.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/f ile.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/l ru.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/l ru.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/m essage.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/m essage.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/m ounts.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/m ounts.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/n otify.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/n otify.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/n v.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/o bject-attr.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/o bject-attr.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/o bject.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/o bject.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/p olicy.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/p olicy.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/p rocess.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/p rocess.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/r ules.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/r ules.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/s ubject-attr.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/s ubject-attr.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/s ubject.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/s ubject.h fapolicyd.src: W: spelling-error %description -l en_US whitelisting -> white listing, white-listing, whitewashing fapolicyd.src: W: spelling-error %description -l en_US fanotify -> fa notify, fa-notify, notify fapolicyd.src: W: file-size-mismatch fapolicyd-0.8.5.tar.gz = 398677, https://people.redhat.com/sgru bb/fapolicyd/fapolicyd-0.8.5.tar.gz = 398610 4 packages and 0 specfiles checked; 29 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory fapolicyd-debuginfo.x86_64: W: invalid-url URL: http://people.redhat.com/sgrubb/fapolicyd <urlopen e rror [Errno -2] Name or service not known> fapolicyd-debugsource.x86_64: W: invalid-url URL: http://people.redhat.com/sgrubb/fapolicyd <urlopen error [Errno -2] Name or service not known> fapolicyd-debugsource.x86_64: W: no-documentation fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/e vent.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/e vent.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/f apolicyd.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/f ile.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/f ile.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/l ru.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/l ru.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/m essage.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/m essage.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/m ounts.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/m ounts.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/n otify.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/n otify.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/n v.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/o bject-attr.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/o bject-attr.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/o bject.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/o bject.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/p olicy.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/p olicy.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/p rocess.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/p rocess.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/r ules.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/r ules.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/s ubject-attr.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/s ubject-attr.h fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/s ubject.c fapolicyd-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/fapolicyd-0.8.5-1.x86_64/src/s ubject.h fapolicyd.x86_64: W: spelling-error %description -l en_US whitelisting -> white listing, white-listi ng, whitewashing fapolicyd.x86_64: W: spelling-error %description -l en_US fanotify -> fa notify, fa-notify, notify fapolicyd.x86_64: W: invalid-url URL: http://people.redhat.com/sgrubb/fapolicyd <urlopen error [Errn o -2] Name or service not known> fapolicyd.x86_64: W: non-standard-gid /etc/fapolicyd fapolicyd fapolicyd.x86_64: E: non-standard-dir-perm /etc/fapolicyd 750 fapolicyd.x86_64: W: non-standard-gid /etc/fapolicyd/fapolicyd.mounts fapolicyd fapolicyd.x86_64: W: non-standard-gid /etc/fapolicyd/fapolicyd.mounts fapolicyd fapolicyd.x86_64: W: non-standard-gid /etc/fapolicyd/fapolicyd.rules fapolicyd fapolicyd.x86_64: W: log-files-without-logrotate ['/var/log/fapolicyd-access.log'] 3 packages and 0 specfiles checked; 29 errors, 10 warnings. Source checksums ---------------- https://people.redhat.com/sgrubb/fapolicyd/fapolicyd-0.8.5.tar.gz : CHECKSUM(SHA256) this package : 225436757118535b6ffd5a87b8fb9f560599a46954edcab581bd51c4586ab4 5f CHECKSUM(SHA256) upstream package : 10a18cb18a835911599d62bc10e2268105dac37453420e19509fa43bd88a01 74 diff -r also reports differences ==================================================================== Why are you using /sbin in configure? On your github you are working with /usr/sbin. Working with /sbin is not standard. And why are you using runtime arguments with %configure? Why are you ghosting the log file? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
