https://bugzilla.redhat.com/show_bug.cgi?id=1507103 --- Comment #36 from Jan Friesse <jfriesse@xxxxxxxxxx> --- @digimer: >From my point of view, package is almost ready to pass all the required test, but there are still few left: - Please remove %defattr(-,root,root,-) everywhere - For kronosnetd: * Requires(preun): shadow-utils <-- not needed * groupadd --force kronosnetadm <-- kronosnetadm should be system account (and force is not needed), so result should be "groupadd -r kronosnetadm" * %systemd_post kronosnetd.service <-- I believe there was small misunderstanding. So the question is, if you want to keep compatibility with non-systemd systems (whole spec is written that way), then stanza should look like: ``` %if %{defined _unitdir} %systemd_post kronosnetd.service %else /sbin/chkconfig --add kronosnetd %endif ``` * Please fix the "%preun -n kronosnetd" section similar way * Add %{?systemd_requires} (conditionally) * Add postun: ``` %postun -n kronosnetd %if %{defined _unitdir} %systemd_postun kronosnetd.service %endif ``` - Missing "BuildRequires: systemd" (probably conditional) so something like ``` %if %{defined _unitdir} && %{defined buildkronosnetd} BuildRequires: systemd %endif ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
