https://bugzilla.redhat.com/show_bug.cgi?id=1544468 Steve Grubb <sgrubb@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sgrubb@xxxxxxxxxx | |) | --- Comment #4 from Steve Grubb <sgrubb@xxxxxxxxxx> --- (In reply to Marek Tamaskovic from comment #3) > Missing: 'BuildRequires: systemd-devel' I think we are good here. The report in Comment #1 was that the -devel needed to go. I check the systemd guidelines and that appears true: https://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations rpm -ql systemd-devel shows nothing useful unless you are building a C program against libsystemd. > BuildRequires - no multiple requires in one line. Every package should be on > unique line. I can't find this in the packaging guidelines. Packaging guidelines just say all dependencies need to be stated. https://fedoraproject.org/wiki/Packaging:Guidelines#Build-Time_Dependencies_.28BuildRequires.29 > In files use macros i.e. etc: %{_sysconfdir} == /etc Fixed. New spec and SRPM posted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
