https://bugzilla.redhat.com/show_bug.cgi?id=1544468 --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - Not used in Fedora anymore: Group: BuildRoot: rm -rf $RPM_BUILD_ROOT %defattr(-,root,root,-) - Use the correct systemd macros: %{?systemd_requires} BuildRequires: systemd - the license file must be included with %license, not %doc: %files %doc README %license COPYING - These %attr(644,root,root) %attr(755,root,root) are not needed because they are already the default value. - COPYING contains GNU General Public License v3.0 but your license header contains GPLv2+. Please use GPLv3 or GPLv3+. - Please follow https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation to add user and group. Add Requires(pre): shadow-utils %pre getent group GROUPNAME >/dev/null || groupadd -r GROUPNAME getent passwd USERNAME >/dev/null || \ useradd -r -g GROUPNAME -d HOMEDIR -s /sbin/nologin \ -c "Useful comment about the purpose of this account" USERNAME exit 0 - In %files, for man pages, don't directly link to the gz extension but use a glob: %{_mandir}/man8/fapolicyd.8.* %{_mandir}/man5/fapolicyd.rules.5.* See https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages for rationale. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
