[Bug 1544081] Review Request: grc - Generic Colorizer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1544081



--- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> ---
Spec URL: https://cheeselee.fedorapeople.org/grc.spec
SRPM URL: https://cheeselee.fedorapeople.org/grc-1.11.1-2.fc28.src.rpm

- Remove unnecessary BR python2-devel


(In reply to Robert-André Mauchin from comment #1)
>  - Use %{version} in Source0:
> 
> Source0:       
> https://github.com/garabik/grc/archive/v%{version}/%{name}-%{version}.tar.gz
> 
>  - Seems to work with python3: https://github.com/garabik/grc/blob/master/grc
> 
> You should depend on python3-devel instead.
Fixed.

> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> =======
> - Package does not use a name that already exists.
>   Note: A package with this name already exists. Please check
>   https://admin.fedoraproject.org/pkgdb/package/grc
>   See:
>  
> https://fedoraproject.org/wiki/Packaging/
> NamingGuidelines#Conflicting_Package_Names
The existing 'grc' is retired for since 2013.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux