https://bugzilla.redhat.com/show_bug.cgi?id=1542522 Iwicki Artur <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Iwicki Artur <fedora@xxxxxxxxxx> --- >Group: Development/Languages The Group: tag is not used in Fedora. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >License: Apache-2.0 The correct identifier for the Apache Software Licence v.2.0 in Fedora is "ASL 2.0". https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses >%package devel As a general rule, devel packages should have a "Requires: %{name}%{?_isa} = %{version}-%{release}"; this ensures that you can't install devel headers for a different version of the library than the .so files provide. >%package lib Someone correct me if I'm wrong, but I think the preferred way is to have "libSOMETHING", like "%package -n libjsonnet". The development headers would then become "%package -n libjsonnet-devel". >%if 0%{?fedora} >= 21 >%package python3 Seeing how Fedora 25 has been put to its grave almost two months ago, this conditional can be removed. >%{__make} It is preferred to use non-macro forms of system executables. https://fedoraproject.org/wiki/Packaging:Guidelines#Macros You should also include the licence text in the packages, by putting the following in %files: "%license LICENSE" https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
