[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #24 from Antonio Trande <anto.trande@xxxxxxxxx> ---
- Openbabel features do not work yet.

- ldconfig scriplets are not needed if you install libraries in a private
directory.

- /usr/lib64/molsketch directory is not owned.
  Use the line

%{_libdir}/%{name}/

- You're installing duplicate libraries with devel sub-package

Remove

%{_libdir}/%{name}/lib%{name}*so
%{_libdir}/%{name}/libobabeliface*so

- Diff spec file in url and in SRPM.
  See rpmlint's output.

- Not all headers are installed; see the list below.
  Respect the directories too; for example:

 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractitemaction.h

is installed as

  /usr/include/libmolsketch/actions/abstractitemaction.h

and so on.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/ringaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/rotateaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/textaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/transformcommand.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/arrow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/atom.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/bond.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/boundingboxlinker.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/commands.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/constants.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/coordinatedelegate.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/coordinatemodel.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/coordinatetableview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/electronsystem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/element.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/fileio.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/frame.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/generics.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/graphicsitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/grid.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/helptextemptydock.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/helptextonemptylabel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/librarymodel.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/libraryview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/lineupaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/lonepair.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/math2d.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/mimemolecule.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/molecule.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/moleculemodelitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/moleculepopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/molscene.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/molview.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/propertieswidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/radicalelectron.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/scenepropertiesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/scenesettings.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/stringify.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/textitem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_alignrowdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_moleculepopup.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_scenepropertiesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/ui_typelistdialog.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/xmlobjectinterface.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/applicationsettings.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/helpforemptytoolbox.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/indicator.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/librarylistwidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/mainwindow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/obabelifaceloader.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/optimizestructureaction.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/programversion.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/releasenotesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/settingsdialog.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/ui_releasenotesdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/ui_settingsdialog.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/ui_wikiquerywidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/molsketch/wikiquerywidget.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/obabeliface/obabeliface.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later) (with incorrect FSF address)", "Unknown or
     generated", "*No copyright* GPL". 189 files have unknown license.
     Detailed output of licensecheck in
     /home/sagitter/1536852-molsketch/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/molsketch
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/molsketch,
     /usr/share/mime, /usr/share/mime/packages
[x]: Package does not own files or directories owned by other packages.
     ...
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: molsketch
     See:
     http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     molsketch-doc , molsketch-debuginfo , molsketch-debugsource
[!]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: molsketch-0.5.1-5.fc28.x86_64.rpm
          molsketch-doc-0.5.1-5.fc28.noarch.rpm
          molsketch-devel-0.5.1-5.fc28.x86_64.rpm
          molsketch-debuginfo-0.5.1-5.fc28.x86_64.rpm
          molsketch-debugsource-0.5.1-5.fc28.x86_64.rpm
          molsketch-0.5.1-5.fc28.src.rpm
molsketch.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/molsketch/libmolsketch-qt5.so
molsketch.x86_64: E: incorrect-fsf-address
/usr/share/licenses/molsketch/COPYING
molsketch.x86_64: W: no-manual-page-for-binary molsketch-qt5
molsketch-doc.noarch: W: invalid-url URL: http://molsketch.sourceforge.net
<urlopen error [Errno -2] Name or service not known>
molsketch-doc.noarch: E: incorrect-fsf-address
/usr/share/licenses/molsketch-doc/COPYING
molsketch-devel.x86_64: W: no-documentation
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
molsketch-debugsource.x86_64: W: no-documentation
molsketch.src: W: invalid-url Source0:
https://downloads.sourceforge.net/molsketch/Molsketch-latest-src.tar.gz
<urlopen error _ssl.c:786: The handshake operation timed out>
6 packages and 0 specfiles checked; 3 errors, 6 warnings.




Rpmlint (debuginfo)
-------------------
Checking: molsketch-debuginfo-0.5.1-5.fc28.x86_64.rpm
          molsketch-devel-debuginfo-0.5.1-5.fc28.x86_64.rpm
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
2 packages and 0 specfiles checked; 1 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
molsketch-devel.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net
<urlopen error [Errno -2] Name or service not known>
molsketch-devel.x86_64: W: no-documentation
molsketch-doc.noarch: W: invalid-url URL: http://molsketch.sourceforge.net
<urlopen error [Errno -2] Name or service not known>
molsketch-doc.noarch: E: incorrect-fsf-address
/usr/share/licenses/molsketch-doc/COPYING
molsketch-devel-debuginfo.x86_64: W: invalid-url URL:
http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not
known>
molsketch.x86_64: W: invalid-url URL: http://molsketch.sourceforge.net <urlopen
error [Errno -2] Name or service not known>
molsketch.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/molsketch/libmolsketch-qt5.so
molsketch.x86_64: E: incorrect-fsf-address
/usr/share/licenses/molsketch/COPYING
molsketch.x86_64: W: no-manual-page-for-binary molsketch-qt5
molsketch-debugsource.x86_64: W: invalid-url URL:
http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not
known>
molsketch-debugsource.x86_64: W: no-documentation
molsketch-debuginfo.x86_64: W: invalid-url URL:
http://molsketch.sourceforge.net <urlopen error [Errno -2] Name or service not
known>
molsketch-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
6 packages and 0 specfiles checked; 3 errors, 10 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/sagitter/1536852-molsketch/srpm/molsketch.spec    2018-02-08
12:32:45.478711247 +0100
+++ /home/sagitter/1536852-molsketch/srpm-unpacked/molsketch.spec    2018-02-07
20:13:25.000000000 +0100
@@ -78,5 +78,8 @@


-%ldconfig_scriptlets
+%post -p /sbin/ldconfig
+
+
+%postun -p /sbin/ldconfig


@@ -107,6 +110,5 @@
 %changelog
 * Wed Feb 07 2018 Alexander Ploumistos <alexpl@xxxxxxxxxxxxxxxxx> - 0.5.1-5
-- New version with refactored installation
-- Use ldconfig scriptlets
+- New version with refactored installation 

 * Mon Jan 22 2018 Alexander Ploumistos <alexpl@xxxxxxxxxxxxxxxxx> - 0.5.1-4


Requires
--------
molsketch (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    hicolor-icon-theme
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.10)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5PrintSupport.so.5()(64bit)
    libQt5PrintSupport.so.5(Qt_5)(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Svg.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmolsketch-qt5.so.0()(64bit)
    libopenbabel.so.5()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    openbabel(x86-64)
    rtld(GNU_HASH)

molsketch-devel (rpmlib, GLIBC filtered):
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.10)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5PrintSupport.so.5()(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmolsketch-qt5.so.0()(64bit)
    libopenbabel.so.5()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    molsketch(x86-64)
    qt5-qttools-devel
    rtld(GNU_HASH)

molsketch-doc (rpmlib, GLIBC filtered):

molsketch-debugsource (rpmlib, GLIBC filtered):

molsketch-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
molsketch:
    application()
    application(molsketch.desktop)
    libmolsketch-qt5.so.0()(64bit)
    libobabeliface-qt5.so()(64bit)
    metainfo()
    metainfo(net.sourceforge.molsketch.appdata.xml)
    mimehandler(application/x-molsketch)
    molsketch
    molsketch(x86-64)

molsketch-devel:
    libobabeliface-qt5.so()(64bit)
    molsketch-devel
    molsketch-devel(x86-64)

molsketch-doc:
    molsketch-doc

molsketch-debugsource:
    molsketch-debugsource
    molsketch-debugsource(x86-64)

molsketch-debuginfo:
    debuginfo(build-id)
    molsketch-debuginfo
    molsketch-debuginfo(x86-64)



Unversioned so-files
--------------------
molsketch: /usr/lib64/molsketch/libmolsketch-qt5.so
molsketch: /usr/lib64/molsketch/libobabeliface-qt5.so

Source checksums
----------------
https://downloads.sourceforge.net/molsketch/Molsketch-latest-src.tar.gz :
  CHECKSUM(SHA256) this package     :
df9923929431829921badf467a7674c2ebf53138ff29e6e0a83fb4e363858ef3
  CHECKSUM(SHA256) upstream package :
df9923929431829921badf467a7674c2ebf53138ff29e6e0a83fb4e363858ef3


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1536852
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux