https://bugzilla.redhat.com/show_bug.cgi?id=1542650 Ben Rosser <rosser.bjr@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #1 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- There seem to be some unit tests that aren't run. The README says: > Also, if Qt4's QtTest or Qt5's Qt5Test modules are found during the pre-build configuration, the unit tests are enabled and can be run with `make test` command. It looks as though the test binary "test_QEverCloud" is indeed getting built according to the log file. Is it possible to run these in %check? In addition, rpmlint says: qevercloud.x86_64: E: library-without-ldconfig-postin /usr/lib64/libqt5qevercloud.so.4.0.0 qevercloud.x86_64: E: library-without-ldconfig-postun /usr/lib64/libqt5qevercloud.so.4.0.0 This was recently discussed on the devel list. The takeaway from the change proposal page seems to be that this is fine if you only want to support Fedora 28+, but if you want to backport this to older releases, make sure to add the ldconfig post scriplets (or use the new macros): https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets#Upgrade.2Fcompatibility_impact Otherwise, the package looks fine. Since neither of the above issues are blockers, I'm going to go ahead and approve it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
