https://bugzilla.redhat.com/show_bug.cgi?id=1540553 --- Comment #2 from Kaushal <kshlmster@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - You're missing %{?dist} in Release > > - Doesn't this service require its own user and group? > > - Don't use: > > Requires(post): systemd > Requires(preun): systemd > Requires(postun): systemd > > Use the provided macro instead: > > %{?systemd_requires} > BuildRequires: systemd > > - Also building with vendored is a no go, you will need to unbundle each > dependency in vendor. Yes, it's gonna be a big task. Use gofed to do most of > the work. Thanks for the comments. I will be updating the spec with the suggested changes. About the bundled vendored packages, that will require some work as we'll need to ensure that we run with the versions Fedora has packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
