https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > File "/usr/lib/python3.6/site-packages/patoolib/configuration.py", line 5, in <module> > import _patool_configdata as configdata Yeah, that'd require changing the code… Other packages you quote don't installl *private* modules. Top-level single-file modules are OK, it's just the ones that start with "_" that bother me. Anyway, that's an RFE, not something that matters for package review. > %{__install} There's no benefit over using plain "install". pytest-{2,3} should be called -v so that the tests are listed. I'm not sure about the Recommends: some of those binaries are not available in Fedora. Not sure what dnf does in that case, but it'll at least warn. You might want to comment those out until they are available. If all those binaries are available in the build environment, tests fail, see attached file. You should add whatever as much as possible to BR and then fix the tests or filter them out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
