[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #4 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> %check
> make test
> 
> %install

During rpmbuild, %check gets executed _after_ %install, so putting %check below
%install in the spec file is common practice. Sometimes tests are run on
buildroot contents, btw, which explains the order of those sections.


> %package static
> Requires: %{name}-devel = %{version}-%{release}

Make it arch-specific as explained in the base package guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %{_includedir}/primesieve/PrimeSieve.hpp

If you list individual files like that (which may be beneficial because the
build would abort for added/removed files), you need to specify also
directories:

  %dir %{_includedir}/primesieve

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux