https://bugzilla.redhat.com/show_bug.cgi?id=1542561 Tomas Tomecek <ttomecek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ --- Comment #1 from Tomas Tomecek <ttomecek@xxxxxxxxxx> --- Two notes inline. These don't block the review. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: sources don't contain short license in their header, this will be fixed in next upstream release: https://github.com/fedora-modularity/conu/issues/137 [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python2.7/site- packages/conu/backend/docker(python2-conu, conu), /usr/lib/python2.7 /site-packages/conu(python2-conu, conu), /usr/lib/python2.7/site- packages/conu/backend(python2-conu, conu), /usr/lib/python2.7/site- packages/conu/utils(python2-conu, conu), /usr/lib/python2.7/site- packages/conu/apidefs(python2-conu, conu) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-conu , python3-conu , conu-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-conu-0.2.0-1.fc28.noarch.rpm python3-conu-0.2.0-1.fc28.noarch.rpm conu-doc-0.2.0-1.fc28.noarch.rpm conu-0.2.0-1.fc28.src.rpm python2-conu.noarch: W: summary-not-capitalized C library which makes it easy to write tests for your containers python3-conu.noarch: W: summary-not-capitalized C library which makes it easy to write tests for your containers conu-doc.noarch: W: summary-not-capitalized C conu documentation conu.src: W: summary-not-capitalized C library which makes it easy to write tests for your containers 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Note: This warning doesn't block the review: please capitalize the summary and also propose the change upstream. Rpmlint (installed packages) ---------------------------- conu-doc.noarch: W: summary-not-capitalized C conu documentation conu-doc.noarch: W: invalid-url URL: https://github.com/fedora-modularity/conu <urlopen error [Errno -2] Name or service not known> python2-conu.noarch: W: summary-not-capitalized C library which makes it easy to write tests for your containers python2-conu.noarch: W: invalid-url URL: https://github.com/fedora-modularity/conu <urlopen error [Errno -2] Name or service not known> python3-conu.noarch: W: summary-not-capitalized C library which makes it easy to write tests for your containers python3-conu.noarch: W: invalid-url URL: https://github.com/fedora-modularity/conu <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- conu-doc (rpmlib, GLIBC filtered): python2-conu (rpmlib, GLIBC filtered): docker python(abi) python2-docker python2-enum34 python2-requests python2-six pyxattr python3-conu (rpmlib, GLIBC filtered): docker python(abi) python3-docker python3-pyxattr python3-requests python3-six pyxattr source-to-image Provides -------- conu-doc: conu-doc python2-conu: python-conu python2-conu python2.7dist(conu) python2dist(conu) python3-conu: python3-conu python3.6dist(conu) python3dist(conu) Source checksums ---------------- https://files.pythonhosted.org/packages/source/c/conu/conu-0.2.0.tar.gz : CHECKSUM(SHA256) this package : 02a62f26e64a41c91f2cd39aa1c517dd965aba09f1ce2913333a59605735045d CHECKSUM(SHA256) upstream package : 02a62f26e64a41c91f2cd39aa1c517dd965aba09f1ce2913333a59605735045d Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/bin/fedora-review -v -b 1542561 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
