https://bugzilla.redhat.com/show_bug.cgi?id=1541346 --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - RPMLint error: > > phpunit7.noarch: E: wrong-script-interpreter /usr/bin/phpunit7 /usr/bin/env > php > > Policy is not to use env in Fedora. What is the motivation for removing > brp_mangle_shebangs ? Because I don't agree with this Guidelines. Such packages works perfectly with different PHP versions (for most PHP projects, compatibility with newer PHP version is considered as a standard feature, and when needed, fixed as a bug) This is commonly used in travis, daily, by tons of project to ensure compatibility with various PHP versions. Having this package locked with default version will make no sense, making it unusable, and this will encourage php users to use the upstream distribution (.phar file) instead of this package. This is described in https://blog.remirepo.net/post/2016/04/16/My-PHP-Workstation (§ Working on PHP code) This specific version doesn't support old PHP version, but handles this properly $ module load php56 $ phpunit7 This version of PHPUnit is supported on PHP 7.1 and PHP 7.2. You are using PHP 5.6.33 (/opt/remi/php56/root/usr/bin/php). When I submit this review this was still under discussion by FPC as https://pagure.io/packaging-committee/issue/725 is now rejected, I'm sad So I you prefer, I can remove the macro for the review (well... to be honest... I will probably re-add it later) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
