https://bugzilla.redhat.com/show_bug.cgi?id=1119197 --- Comment #20 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- copr is fine for scratch builds these days (it uses Koji behind the scenes). Just a note, generally it's good to run "rpmlint" over your package before uploading (e.g. "rpmlint [rpm]"). It frequently produces spurious warnings that can safely be ignored (like "spelling errors"), but it can also detect actual problems. In this instance it found a few complaints. On a related note, I'd encourage you to use the template format of: > Spec URL: > SRPM URL: when posting changes in a review ticket-- this makes it possible for the automated "fedora-review" tool to run properly. You can try running this yourself over a review ticket if you have mock installed: $ dnf install fedora-review $ fedora-review -b [bugzilla ID] -m fedora-rawhide-x86_64 This will try to fetch the spec and SRPM from bugzilla and automatically build and run some checks over them. (fedora-review can also be given files locally, but that adds a step for the reviewer of having to download the tickets). Anyway, here are a few problems pointed out by rpmlint: > gnushogi.x86_64: E: description-line-too-long C GNU shogi is a program that plays shogi, the Japanese version of chess, against a human (or computer) opponent. > gnushogi.x86_64: E: description-line-too-long C GNU Shogi proper is only the AI engine, and you will likely want to use a GUI frontend (XBoard, for example) to be more comfortable. The lines in %description should be wrapped to 80 characters. https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description > gnushogi.x86_64: W: incoherent-version-in-changelog 1.5.0.2.git5bb0b5b ['1.5-0.2.git5bb0b5b.fc28', '1.5-0.2.git5bb0b5b'] Looks like you just made a small typo here, though it looks like you fixed it in the spec after building the SRPM. (In general, you should make sure that the version of the spec you upload is the same as the one you use to build the SRPM. For simple things like this it doesn't really matter, but it's just generally good practice). > gnushogi.x86_64: E: shell-syntax-error-in-%post > gnushogi.x86_64: E: shell-syntax-error-in-%preun You seem to be missing "; then" after your conditionals: https://gist.github.com/aflyhorse/dc5f37bd72008315ac323f66b88ead1e#file-gnushogi-spec-L48 https://gist.github.com/aflyhorse/dc5f37bd72008315ac323f66b88ead1e#file-gnushogi-spec-L58 When I attempted to install the RPM, I got similar errors from dnf. In addition, I then tried to run gnushogi. It seems it wants to write out it's .bbk file in /usr/lib64/gnushogi, which is not user-writable. Looking at the documentation (doc/BOOKFILES), I believe "make -C gnushogi gnushogi.bbk" should be run under %build, in order to pre-compile the binary book file. Please fix the above, and I'll be more than happy to approve the package and sponsor you-- everything else looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
