[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1535207



--- Comment #4 from Raphael Groner <projects.rg@xxxxxxxx> ---
Thanks for the reminder and sorry for the delay. I hoped we can wait for a new
release from upstream including latest (important) fixes. Maybe you want to
package a pre-release or shapshot?


*No copyright* Apache (v2.0)
----------------------------
ravada-0.2.12/public/css/sb-admin.css
ravada-0.2.12/public/js/main.js

Add ASL 2.0 to License tag with a breakdown for above files in a comment,
they're obviously taken from startbootstrap.com templates.


Rpmlint
-------
Checking: ravada-0.2.12-1.fc28.noarch.rpm
          ravada-0.2.12-1.fc28.src.rpm
ravada.noarch: E: explicit-lib-dependency libvirt-daemon-kvm
ravada.noarch: E: explicit-lib-dependency libvirt-daemon-lxc
=> Maybe remove.
ravada.noarch: E: zero-length
/usr/share/ravada/public/css/custom/insert_here_custom_css
ravada.noarch: E: zero-length
/usr/share/ravada/public/img/custom/insert_here_custom_images
ravada.noarch: E: zero-length
/usr/share/ravada/public/js/custom/insert_here_custom_javascripts
ravada.noarch: E: zero-length
/usr/share/ravada/templates/main/custom/insert_here_custom_template
=> Remove.
ravada.noarch: W: no-manual-page-for-binary rvd_back.pl
ravada.noarch: W: no-manual-page-for-binary rvd_front.pl
ravada.src: W: file-size-mismatch ravada-0.2.12.tar.gz = 1333333,
https://github.com/UPC/ravada/archive/0.2.12/ravada-0.2.12.tar.gz = 1333228
2 packages and 0 specfiles checked; 6 errors, 3 warnings.


Source checksums
----------------
https://github.com/UPC/ravada/archive/0.2.12/ravada-0.2.12.tar.gz :
  CHECKSUM(SHA256) this package     :
621523e70abecc028f2985f63131e73a7fd3af64b7c68920b50979576fb5338d
  CHECKSUM(SHA256) upstream package :
f7a91597a5f11374743daaa87d00314ecb015c9a2d7297200569beb07107b8d3
diff -r also reports differences

diff -U2 -r
/home/builder/fedora-review/1535207-ravada/upstream-unpacked/Source0/ravada-0.2.12/lib/Ravada.pm
/home/builder/fedora-review/1535207-ravada/srpm-unpacked/ravada-0.2.12.tar.gz-extract/ravada-0.2.12/lib/Ravada.pm
---
/home/builder/fedora-review/1535207-ravada/upstream-unpacked/Source0/ravada-0.2.12/lib/Ravada.pm
   2018-01-22 10:02:48.000000000 +0100
+++
/home/builder/fedora-review/1535207-ravada/srpm-unpacked/ravada-0.2.12.tar.gz-extract/ravada-0.2.12/lib/Ravada.pm
  2018-01-16 15:48:42.000000000 +0100
@@ -4,5 +4,5 @@
 use strict;

-our $VERSION = '0.2.12';
+our $VERSION = '0.2.12-rc1';

 use Carp qw(carp croak);


All other look good so far.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux