[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1540726



--- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - go-bindata only provides a binary, not a library, and only the binary is
needed for your package. See https://src.fedoraproject.org/rpms/go-bindata

   So just replace golang(github.com/jteeuwen/go-bindata) with "go-bindata"

   I'm not even sure you even need it since it's only used in the make script
that you don't use anyway. It seems to be used only by the developer. It's safe
to remove imho.

 - Where did you get your Version:        2.0.0 from?

According to
https://github.com/evilsocket/bettercap-ng/blob/master/core/banner.go the
latest version is 0.9.

You should ask upstream to tag its release, it would be easier for packaging.

 - This import path seems dubious:

 %global import_path     code.google.com/p/go.net

It's not needed for packaging a binary anyway.

 - This:

%doc
README.md

%license
LICENSE.md

   should be inline, they are not new sections of the SPEC:

%files
%doc README.md
%license LICENSE.md
%{_bindir}/%{name}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux