[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #6 from Satoru SATOH <ssato@xxxxxxxxxx> ---
Troy-san, thanks a lot for your comments!

(In reply to Troy Curtis from comment #3)
> The version suffixes are for the corresponding python version.
> 
> %{python2_version} and %{python3_version} already have the minor version,
> for instance 2.7, and 3.6.  So the move would be:
> 
> mv %{buildroot}%{_bindir}/anyconfig_cli
> %{buildroot}%{_bindir}/anyconfig_cli-%{python3_version}

I guess that I made so already by the previous commits I mentioned:

ssato@localhost% rpm -ql python2-anyconfig | grep anyconfig_cli |
LC_ALL=en_US.UTF-8 xargs ls -l
lrwxrwxrwx. 1 root root   17 Feb  1 23:04 /usr/bin/anyconfig_cli ->
anyconfig_cli-2.7
lrwxrwxrwx. 1 root root   17 Feb  1 23:04 /usr/bin/anyconfig_cli-2 ->
anyconfig_cli-2.7
-rwxr-xr-x. 1 root root  400 Feb  1 23:04 /usr/bin/anyconfig_cli-2.7
lrwxrwxrwx. 1 root root   22 Feb  1 23:04
/usr/share/man/man1/anyconfig_cli.1.gz -> anyconfig_cli-2.7.1.gz
lrwxrwxrwx. 1 root root   22 Feb  1 23:04
/usr/share/man/man1/anyconfig_cli-2.1.gz -> anyconfig_cli-2.7.1.gz
-rw-r--r--. 1 root root 1724 May  3  2017
/usr/share/man/man1/anyconfig_cli-2.7.1.gz
ssato@localhost% rpm -ql python3-anyconfig | grep anyconfig_cli |
LC_ALL=en_US.UTF-8 xargs ls -l
lrwxrwxrwx. 1 root root   17 Feb  1 23:04 /usr/bin/anyconfig_cli-3 ->
anyconfig_cli-3.6
-rwxr-xr-x. 1 root root  400 Feb  1 23:04 /usr/bin/anyconfig_cli-3.6
lrwxrwxrwx. 1 root root   22 Feb  1 23:04
/usr/share/man/man1/anyconfig_cli-3.1.gz -> anyconfig_cli-3.6.1.gz
-rw-r--r--. 1 root root 1724 May  3  2017
/usr/share/man/man1/anyconfig_cli-3.6.1.gz
ssato@localhost%

> And for the python2 subpackage, don't copy the executable for the
> unversioned executable, just add a second symlink:
> 
> ln -s anyconfig_cli-%{python3_version} %{buildroot}%{_bindir}/anyconfig_cli

I've fixed it:
https://github.com/ssato/python-anyconfig/commit/51a7e4fa1376e9daa1b90ea0be861bbf6f4b325d#diff-49f0020084413dbd6fb3815a74500f70

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux