[Bug 1539134] Review Request: bouncycastle1.58 - Bouncy Castle Cryptography APIs for Java

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1539134



--- Comment #2 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #1)
> There's a few fedora-review errors but I don't know how pertinent they are
> regarding EPEL6 packaging, you're using old macros instead of
> %mvn_artifact/%mvn_install because they don't exist in EPEL6?

Correct.

The %mvn_artifact/%mvn_install macros can be used in EPEL7 (where they are part
of the maven-local package) but not in EPEL6.

In EPEL6 the old %add_maven_depmap macro (used in Fedora before
%mvn_artifact/%mvn_install were introduced) does not exist. The even older
%add_to_maven_depmap/%update_maven_depmap macros must be used instead.

The Requires: jpackage-utils is not added automatically to javadoc packages in
EPEL6.

The zero-length file rpmlint complains about is on purpose. All information is
contained in the filename, and the file's content is never read. Compare with
the file in the standard non-compat bouncycastle package (either in Fedora or
EPEL):

$ ls -l
/etc/java/security/security.d/2000-org.bouncycastle.jce.provider.BouncyCastleProvider
-rw-r--r--. 1 root root 0 19 aug 04.26
/etc/java/security/security.d/2000-org.bouncycastle.jce.provider.BouncyCastleProvider

> Issues:
> =======
> - POM files have correct Maven mapping
>   Note: Old style Maven package found, no add_maven_depmap calls found but
>   POM files present
>   See: https://fedoraproject.org/wiki/Packaging:Java#Maven_pom.xml_files
> - Old add_to_maven_depmap macro is being used
> - Javadoc subpackages should not have Requires: jpackage-utils
>   Note: jpackage-utils requires are automatically generated by the
>   buildsystem
>   See: https://fedoraproject.org/wiki/Packaging:Java

> Rpmlint
> -------
> Checking: bouncycastle1.58-1.58-1.el6.noarch.rpm
>           bouncycastle1.58-pkix-1.58-1.el6.noarch.rpm
>           bouncycastle1.58-pg-1.58-1.el6.noarch.rpm
>           bouncycastle1.58-mail-1.58-1.el6.noarch.rpm
>           bouncycastle1.58-tls-1.58-1.el6.noarch.rpm
>           bouncycastle1.58-javadoc-1.58-1.el6.noarch.rpm
>           bouncycastle1.58-1.58-1.el6.src.rpm
> bouncycastle1.58.noarch: E: zero-length
> /etc/java/security/security.d/2158-org.bouncycastle.jce.provider.
> BouncyCastleProvider
> 7 packages and 0 specfiles checked; 1 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux