[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #18 from digimer <digimer@xxxxxxxxxx> ---
I am super new to this, so I am somewhat reluctant to stick my neck out, but
then that's never stopped me before... :)

Jan's way is more compact, but it took me longer to parse what the string was
doing. Once I got the logic, it is cleaner and smaller.

On the other hand, the original way is more verbose, but it is a bit easier to
grasp (particularly for those like me who are still newish to RPM/spec). I've
always *personally* been a fan of longer-if-easier-to-grasp. (This is a common
debate in the perl community, where I've landed on the "no one liners!" side).

For spec though, I'm on the fence because I just don't know enough.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux