https://bugzilla.redhat.com/show_bug.cgi?id=1507103 --- Comment #11 from Jan Pokorný <jpokorny@xxxxxxxxxx> --- I'll happily assign myself as a reviewer if there're no complaints. For a start, the spec is needlessly overcomplicated around conditionals: - instead of > %bcond_without sctp > [...] > %if %{with sctp} > %global buildsctp 1 > %endif > [...] > %if %{defined buildsctp} > BuildRequires: lksctp-tools-devel > %endif > > [...] > > %build > [...] > %{configure} \ > %if %{defined buildsctp} > --enable-libknet-sctp \ > %else > --disable-libknet-sctp \ > %endif please use: > %bcond_without sctp > [...] > %if %{with sctp} > BuildRequires: lksctp-tools-devel > %endif > > [...] > > %build > [...] > %{configure} \ > %{?with_sctp:--enable-libknet-sctp} \ > %{!?with_sctp:--disable-libknet-sctp} \ where the latter part can even be compacted as: > %build > [...] > %{configure} \ > --%{?with_sctp:en}%{!?with_sctp:dis}able-libknet-sctp} \ See also: http://rpm.org/user_doc/conditional_builds.html * * * Another spot from this first sight, there are various pieces I believe are already obsolete in Fedora, e.g.: > Requires(post): systemd-sysv > Requires(post): systemd-units > Requires(preun): systemd-units > Requires(postun): systemd-units See e.g.: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/LLG4T53FW2BGVZLGLKNYTKPD5SQNBZ2Y/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
