https://bugzilla.redhat.com/show_bug.cgi?id=1539116 --- Comment #6 from markusN <neteler@xxxxxxxxx> --- Thanks to both for the quick review. (In reply to Iwicki Artur from comment #5) > >Group: Applications/Engineering > The "Group:" tag is not used in Fedora. > > ># EPEL7 fails on url tag, so we ignore failure: > >appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/*.appdata.xml || echo "Ignoring appstream-util failure" > > What exactly is the error here? This one: appstream-util validate-relax --nonet /builddir/build/BUILDROOT/grass-7.4.0-2.el7.centos.x86_64//usr/share/appdata/grass.appdata.xml /builddir/build/BUILDROOT/grass-7.4.0-2.el7.centos.x86_64//usr/share/appdata/grass.appdata.xml: GLib-GIO-Message: Using the 'memory' GSettings backend. Your settings will not be saved or shared with other applications. FAILED: ? markup-invalid : <id> does not have correct extension for kind Validation of files failed > Could we patch the appdata file so the validation doesn't fail? The "offending" line is this one: <id>org.osgeo.grass</id> Does it need to be <id>org.osgeo.grass.desktop</id> ? > >%post > >/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > > > >%postun > >if [ $1 -eq 0 ] ; then > > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null > > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > >fi > > > >%posttrans > >/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > The icon cache scriplets are no longer used in Fedora. These should be made > EPEL-only. > > Another minor issue I can see is the mixed use of $RPM_BUILD_ROOT and > %buildroot. It is preferred to pick one and stick with it. OK, thanks. I am now testing with an updated SPEC file which includes fixes as per comment 4. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
