Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jetty5 - The Jetty Webserver and Servlet Container https://bugzilla.redhat.com/show_bug.cgi?id=202334 ------- Additional Comments From fitzsim@xxxxxxxxxx 2007-08-27 17:48 EST ------- Looks good. Just a few more points: - jetty.conf: by "comment header" I meant adding a comment to jetty.conf itself (rather than in the spec file, explaining its creation), e.g. indicating the purpose and maybe the format of the file, as well as a reference to documentation describing the use of the file. That would eliminate rpmlint's complaint about it being an empty file and it would be helpful to the would-be jetty administrator. - you added the jsp requirement rather than replacing the jsse requirement. Is jsse needed? (jsse is a virtual provide provided by the JDK packages, and represents a Java <= 1.4 concept, so it shouldn't be necessary if you're requiring Java >= 1.5). - I missed this the first time, but can %{demodir}/webapps just belong to the manual subpackage? If not, can you add a comment to the spec file explaining manual's post section? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review