https://bugzilla.redhat.com/show_bug.cgi?id=1537677 --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- >I don't like virtual BRs all that much, but I can make this change if you think it is an improvement (but I should probably use the full list of used modules then: e.g., the CMakeLists.txt uses more than just Qt5Core from qt5-qtbase). Please do. > I think we should include as many digits as allowed of the commit hash to avoid running into hash collisions. That's unlikely but do as you wish, it's just the usual practice, not a requirement per se. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
