https://bugzilla.redhat.com/show_bug.cgi?id=1537677 --- Comment #2 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> --- > - Use cmake for your BR, as it is usual for KDE packages: > > BuildRequires: cmake(Qt5Core) > BuildRequires: cmake(Qt5Qml) > BuildRequires: cmake(Qt5X11Extras) > BuildRequires: kf5-rpm-macros > BuildRequires: cmake(KF5CoreAddons) > BuildRequires: cmake(KF5KCMUtils) > BuildRequires: cmake(KF5I18n) > BuildRequires: cmake(KF5Plasma) > BuildRequires: cmake(KF5KDELibs4Support) > BuildRequires: cmake(KF5Declarative) > BuildRequires: cmake(KF5Auth) > BuildRequires: cmake(KF5Config) Is it really? All the ones I have seen so far use package names or pkgconfig BRs. But I guess that's because the cmake(*) Provides are a recent addition (which is also why I haven't thought of using them). I don't like virtual BRs all that much, but I can make this change if you think it is an improvement (but I should probably use the full list of used modules then: e.g., the CMakeLists.txt uses more than just Qt5Core from qt5-qtbase). > - The short hash for Github is usually 7 characters long, not 13. According to https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots "The packager MAY include up to 17 characters of additional information after the date." "git" is 3 characters, that leaves up to 14 for the commit version. I think we should include as many digits as allowed of the commit hash to avoid running into hash collisions. I'd put all 64 if I were allowed to. I should change it from 13 to 14 characters though, some older version of the guidelines only allowed up to 13 characters (which is why I picked that number in all my git snapshot packages), now it allows up to 14. You can note that for the GitHub Source0 URL itself (the only part that is ever sent to GitHub), I actually use all 64 digits of the commit hash, not my 13 characters, which are only for the Release tag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
