Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: d3lphin - A file manager for KDE focusing on usability https://bugzilla.redhat.com/show_bug.cgi?id=255561 johan@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johan@xxxxxxxx ------- Additional Comments From johan@xxxxxxxx 2007-08-27 17:03 EST ------- Review: + package builds in mock (x86_64). + rpmlint is silent for SRPM. + rpmlint is silent for RPMS : the dangling symlink warning is normal (provided by kdebase). + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code Not contents. + no static libraries present. + no .pc files present. + no -devel subpackage exists. + no .la files. + translations are available, and proprely installed. + Dose owns the directories it creates. + no duplicates in %files. + icon cache scriptlets used. + Desktop file handled correctly. + file permissions are appropriate. + GUI app, desktop file installed properly APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review