[Bug 1537572] Review Request: corosync-qdevice - The Corosync Cluster Engine Qdevice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1537572

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Remove the old cruft, this is not needed in Fedora:

Group: 

BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

rm -rf %{buildroot} in %install

%clean
rm -rf %{buildroot}

%defattr(-,root,root,-) in %files


 - Use the correct systemd macros:

Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd

   and

BuildRequires: systemd-units
BuildRequires: systemd-devel


  should be simplified to:

%{?systemd_requires}
BuildRequires: systemd

 - Requires(pre): /usr/sbin/useradd is not needed as it is provided by
shadow-utils just above.

 - %systemd_postun should be followed by the service file:

%systemd_postun corosync-qdevice.service

%systemd_postun corosync-qnetd.service

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux