[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #5 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> ---
$ diff 0.5.1-2/molsketch.spec 0.5.1-4/molsketch.spec 
3c3
< Release:        2%{?dist}
---
> Release:        4%{?dist}
5c5
< License:        GPLv2
---
> License:        GPLv2+
16d15
< BuildRequires:  qca
23c22
< Requires:       openbabel
---
> Requires:       openbabel%{?_isa}
36c35
< License:        GPLv2
---
> License:        GPLv2+
47,48c46,47
< Requires:       lib%{name}-qt5
< #Requires:       libqt5-qttools
---
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> Requires:       qt5-qttools-devel
59c58
< #%setup -q -n Molsketch-%{version}
---
> #%%setup -q -n Molsketch-%%{version}
61c60
< #%setup -q -n Molsketch-latest
---
> #%%setup -q -n Molsketch-latest
68c67
< %{qmake_qt5} "MSK_PREFIX=%{_prefix}" "MSK_INSTALL_PREFIX=%{_prefix}"
"MSK_INSTALL_DOCS=%{_docdir}/%{name}" ./Molsketch.pro
---
> %{qmake_qt5} "MSK_PREFIX=%{_prefix}" "MSK_INSTALL_PREFIX=%{_prefix}" "MSK_INSTALL_DOCS=%{_docdir}/%{name}" "MSK_INSTALL_LIBS=%{_libdir}" "MSK_INSTALL_INCLUDES=%{_includedir}/lib%{name}" ./Molsketch.pro
73c72
< make INSTALL_ROOT="%{buildroot}" install
---
> %make_install INSTALL_ROOT="%{buildroot}"
81,82c80
< %post
< /sbin/ldconfig
---
> %post -p /sbin/ldconfig
85,86c83
< %postun
< /sbin/ldconfig
---
> %postun -p /sbin/ldconfig
91c88
< %doc CHANGELOG INSTALL
---
> %doc CHANGELOG
93c90
< %{_libdir}/lib*.so*
---
> %{_libdir}/lib*.so.*
97c94,95
< %{_datadir}/icons/hicolor/scalable/*
---
> %{_datadir}/icons/hicolor/scalable/mimetypes/application-x-%{name}.svg
> %{_datadir}/icons/hicolor/scalable/apps/%{name}.svg
101a100
> %license COPYING
106c105
< %{_includedir}/%{name}
---
> %{_includedir}/lib%{name}
111a111,116
> * Mon Jan 22 2018 Alexander Ploumistos <alexpl@xxxxxxxxxxxxxxxxx> - 0.5.1-4
> - More cleaning up 
> 
> * Mon Jan 22 2018 Alexander Ploumistos <alexpl@xxxxxxxxxxxxxxxxx> - 0.5.1-3
> - Clean up spec file according to remarks by Antonio Trande (rhbz#1536852)
> 
128c133
< - Fix %post & %postun scriptlets
---
> - Fix post & postun scriptlets


Could it be the %{_includedir}/lib%{name} change? Maybe change it to
%{_includedir}/%{name}?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux