https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Michael Cullen <michael@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(michael@cullen-on | |line.com) | --- Comment #7 from Michael Cullen <michael@xxxxxxxxxxxxxxxxx> --- Looking much better in terms of comments! You might want to consider packaging cctz from that Git release (it doesn't seem to be in Fedora at all right now) but it isn't something I'm going to moan about too much. Just one thing about the bundling though: the guidelines [0] require any bundled libraries to be called out in the spec file as provides - something like: Provides: bundled(cctz) = 20171031.4f9776a should do the trick. [0] https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries [1] https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
