[Bug 1535549] Review Request: mupen64plus - Nintendo 64 Emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1535549



--- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
>Question: I changed "%define debug_package" to use "global", is that correct?

   Yes

>What do I need to do about a debuginfo package?

   Indeed, the best would be to generate the debug infos but whatever I try, it
still fails.

   Anyhow you still should enable Fedora's default flags for the build:

%build
export CFLAGS="%{optflags}"
export CXXFLAGS="%{optflags}"
export LDFLAGS="%{?__global_ldflags}"
sh m64p_build.sh LIRC=1

  - Another issue is that the build script install the libraries without the
executable bits. I thought it was what's causing the debug info not to be
generated (binaries must be executable for find-debuginfo to work) but that's
still not it. Still set the executable bits for those:

%install

# NOTE: set LDCONFIG to true so it's not run during this script
./m64p_install.sh DESTDIR=%{buildroot} PREFIX=%{_prefix} MANDIR=%{_mandir}
LIBDIR=%{_libdir} LDCONFIG='true'
find %{buildroot}%{_libdir} -type f -name "*.so*" -exec chmod 0755 "{}" \;


 - You don't need the following Requires:

Requires:    SDL_ttf
Requires:    mesa-libGLU
Requires:    libsamplerate
Requires:    libpng
Requires:    freetype
Requires:    boost

   They are correctly detected automatically, see:

$ rpm -q --requires -p mupen64plus-2.5-3.fc28.x86_64.rpm   | sort -f | uniq -c
      2 /sbin/ldconfig
      1 hicolor-icon-theme
      1 libboost_filesystem.so.1.64.0()(64bit)
      1 libboost_system.so.1.64.0()(64bit)
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.11)(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libc.so.6(GLIBC_2.7)(64bit)
      1 libdl.so.2()(64bit)
      1 libdl.so.2(GLIBC_2.2.5)(64bit)
      1 libfreetype.so.6()(64bit)
      1 libgcc_s.so.1()(64bit)
      1 libgcc_s.so.1(GCC_3.0)(64bit)
      1 libgcc_s.so.1(GCC_3.3.1)(64bit)
      1 libGL.so.1()(64bit)
      1 libGLU.so.1()(64bit)
      1 liblirc_client.so.0()(64bit)
      1 libm.so.6()(64bit)
      1 libm.so.6(GLIBC_2.15)(64bit)
      1 libm.so.6(GLIBC_2.2.5)(64bit)
      1 libpng16.so.16()(64bit)
      1 libpng16.so.16(PNG16_0)(64bit)
      1 libpthread.so.0()(64bit)
      1 libsamplerate.so.0()(64bit)
      1 libsamplerate.so.0(libsamplerate.so.0.0)(64bit)
      1 libsamplerate.so.0(libsamplerate.so.0.1)(64bit)
      1 libSDL2-2.0.so.0()(64bit)
      1 libstdc++.so.6()(64bit)
      1 libstdc++.so.6(CXXABI_1.3)(64bit)
      1 libstdc++.so.6(CXXABI_1.3.8)(64bit)
      1 libstdc++.so.6(CXXABI_1.3.9)(64bit)
      1 libstdc++.so.6(GLIBCXX_3.4)(64bit)
      1 libstdc++.so.6(GLIBCXX_3.4.11)(64bit)
      1 libstdc++.so.6(GLIBCXX_3.4.15)(64bit)
      1 libstdc++.so.6(GLIBCXX_3.4.9)(64bit)
      1 libz.so.1()(64bit)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux