https://bugzilla.redhat.com/show_bug.cgi?id=1535549 --- Comment #5 from Wade Berrier <wberrier@xxxxxxxxx> --- Robert-André, thanks for the comprehensive review. I believe I've made all of the requested changes, and have new updates here: Spec URL: http://berrier.org/tmp/mupen64plus.spec SRPM URL: http://berrier.org/tmp/mupen64plus-2.5-3.fc27.src.rpm I also did some additional cleanups with BuildRequires and Requires, and did a test mock build. Question: I changed "%define debug_package" to use "global", is that correct? What do I need to do about a debuginfo package? NOTE: rpmlint is warning about libsamplerate and libpng, but "rpm -qp --requires" doesn't list those dependencies, where as ldd /usr/lib64/mupen64plus/* does show those dependencies. So, I left those Requires in. Not sure what to do about that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
