[Bug 1535292] Review Request: vagrant-openstack-provider - Vagrant plugin for OpenStack provider

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1535292



--- Comment #2 from greg.hellings@xxxxxxxxx ---
I have addressed all of your comments in the code save one. I'll address it
here:

I do not believe that stackrc is supposed to be executable. It's designed to be
sourced into the current environment, not to be executed as a standalone
script. I believe the shebang line at the top is intended to give syntax
highlighting in vim and similar situations. It's presented as a doc file, so I
don't believe it will be important either way. I'll be happy to make it
executable if that's preferred or edit out the shebang line if you agree it
should be left with 0644 permissions. Either one should resolve the lint error.

Once we have an agreement I'll post the updated SRPM file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux