[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1428202



--- Comment #23 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> ---
Raphael,

Two minor issues:

Please remove %post, %postun and %posttrans sections as per [4] - now it's
obsolete. There was a change recently in that area (see History section of
[4]).

Please remove %attr(644,-,-) in %files section as it shouldn't be used unless
you need to set non-default value. BTW 0644 is already set in %install section
and is the default one as per [5].

Rest looks ok.

[4] https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache
[5] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux