[Bug 1535384] Review Request: tomb - a CLI tool to manage encrypted storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1535384

Iwicki Artur <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #1 from Iwicki Artur <fedora@xxxxxxxxxx> ---
>Patch0: tomb.patch
Ideally, patches should have some description of what they it. It can either be
part of the patch name (like "tomb-do-not-use-usr-env.patch"), or a #comment in
the spec.

>%make_install PREFIX=/usr
Use "%{_prefix}" instead of "/usr".

As a style remark, %install is usually put before %files. It might also be good
to write a simple comment like "# Nothing to build" in the %build section. The
%description could also be a bit longer; the text on the Tomb website seems
friendly enough for this purpose.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux