https://bugzilla.redhat.com/show_bug.cgi?id=1482524 Matthias Runge <mrunge@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@xxxxxxxxxx --- Comment #9 from Matthias Runge <mrunge@xxxxxxxxxx> --- I stumbled upon this by coincidence. Any reason for this not to be in Fedora? Build fails with RPM build errors: File not found: /home/mrunge/rpmbuild/BUILDROOT/ansible-kubespray-2.3.0-1.x86_64/etc/kubespray/ansible.cfg File not found: /home/mrunge/rpmbuild/BUILDROOT/ansible-kubespray-2.3.0-1.x86_64/etc/kubespray/inventory/group_vars/all.yml File not found: /home/mrunge/rpmbuild/BUILDROOT/ansible-kubespray-2.3.0-1.x86_64/etc/kubespray/inventory/group_vars/k8s-cluster.yml - IMHO it would make more sense to name it kubespray. The project is named that way. - The roles are installing into /usr/local/share, which conflicts with FHS https://fedoraproject.org/wiki/Packaging:Guidelines#No_Files_or_Directories_under_.2Fsrv.2C_.2Fusr.2Flocal.2C_or_.2Fhome.2F.24USER - Please update Source0 to https://github.com/kubernetes-incubator/kubespray/archive/v%{upstream_version}.tar.gz#/%{name}-%{version}.tar.gz (additional 'v' in URL and this will save the tarball to a more descriptive name, rather than using v2.3.0.tar.gz) - I'd remove the vendor tag -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
