[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
[+] rpmlint is silent (or produces only messages which can be safely ignored:

Auriga ~/rpmbuild/SPECS: rpmlint ~/rpmbuild/SRPMS/erlang-fs-4.1-1.fc27.src.rpm
~/rpmbuild/RPMS/x86_64/erlang-fs-4.1-1.fc27.x86_64.rpm 
erlang-fs.src: W: spelling-error %description -l en_US inotify -> notify, i
notify, bogotify
erlang-fs.x86_64: W: spelling-error %description -l en_US inotify -> notify, i
notify, bogotify
erlang-fs.x86_64: E: no-binary
erlang-fs.x86_64: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 1 errors, 3 warnings.
Auriga ~/rpmbuild/SPECS:

See Erlang packaging Guidelines for the explanation of these warnings -
https://fedoraproject.org/wiki/User:Peter/Erlang_Packaging_Guidelines

[+] The package is named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format
%{name}.spec.
[+] The package meets the Packaging Guidelines.
[+] The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
[+] The License field in the package spec file matches the actual license
(ISC).
[+] The file, containing the text of the license(s) for the package, is
included in %doc and marked as %license.
[+] The spec file is written in American English.
[+] The spec file for the package is legible.
[+] The sources used to build the package matches the upstream source, as
provided in the spec URL.

Auriga ~/rpmbuild/SOURCES: sha256sum fs-4.1.tar.gz*
3dafd86145ca37aa3bbd69706ef8586f81f7eea89b29d01eb51a609609545303  fs-4.1.tar.gz
3dafd86145ca37aa3bbd69706ef8586f81f7eea89b29d01eb51a609609545303 
fs-4.1.tar.gz.1
Auriga ~/rpmbuild/SOURCES:

[+] The package successfully compiles and builds into binary rpms.
[+] All build dependencies are listed in BuildRequires.
[0] No need to handle locales.
[0] The package does not contain any shared library files.
[+] Packages does not bundle copies of system libraries.
[+] The package isn't designed to be relocatable.
[+] The package owns all directories that it creates.
[+] The package does not list a file more than once in the spec file's %files
listings.
[+] Permissions on files are set properly.
[+] The package consistently uses macros.
[+] The package contains code, or permissible content.
[0] No large documentation files.
[+] Anything, the package includes as %doc, does not affect the runtime of the
application.
[0] No static libraries.
[0] No -devel sub-package.
[+] The package does not contain any .la libtool archives.
[0] Not a GUI application.
[+] The package does not own files or directories already owned by other
packages.
[+] All filenames in rpm packages are valid UTF-8.

I've spotted only the following two issues:

* Missing Requires: inotify-tools
* Erlang dependency generator complains about not available M:F/A, so the
following patch is required -
https://peter.fedorapeople.org/packages/erlang-fs-0001-Unbundle-https-github.com-synrc-mad.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux