https://bugzilla.redhat.com/show_bug.cgi?id=1534446 --- Comment #2 from srakitnican <samuel.rakitnican@xxxxxxxxx> --- Thank you for your review! (In reply to Robert-André Mauchin from comment #1) > - I don't think it's necessary to add Debian packaging files, remove > %license debian/copyright I am confused about that one, I've added this file because it is the only text that describes the actual license used (GPLv2+). COPYING and LICENSE.md contains license text for GPLv3 and LGPLv3 respectively. I am not an expert, but I think there is quiet a difference between the two, and I would say there is at least some difference between GPLv2 and GPLv3. > - Add a "Requires: hicolor-icon-theme" to own the icons directories > > - Add a "Requires: polkit" to own /usr/share/polkit-1 and > /usr/share/polkit-1/actions > > - Add a "Requires: cronie" to own /etc/cron.d > > - Add "%config(noreplace)" for this file unless you don't expect it to be > modified by the user: > > timeshift.x86_64: W: conffile-without-noreplace-flag > /etc/default/timeshift.json I don't think this file is supposed to be modified by user since the program creates and maintaines /etc/timeshift.json. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
